search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Corrected call to islandora_oralhistories_islandora_oralhistoriesCMod… #128

Closed McFateM closed 6 years ago

McFateM commented 6 years ago

Attention @MarcusBarnes
Addresses issue #109.

The call to implement islandora_oralhistories_islandora_oralhistoriesCModel_islandora_derivative() for hook_islandora_CModel_islandora_derivative had an extra argument that was not used. When ingesting objects using the Islandora Multi-Importer this extra argument apparently caused the hook function to be skipped because it's argument list did not fit the pattern required for a valid hook_islandora_CModel_islandora_derivative() function.

I simply removed the unused argument and now IMI appears to invoke the function properly.

MarcusBarnes commented 6 years ago

Thanks @McFateM. I'll review and test.

McFateM commented 6 years ago

Note that I am still having problems with IMI, but from my debugging it appears that is an unrelated issue specific to IMI.

MarcusBarnes commented 6 years ago

Thanks @McFate! Appears to work as expected.