7.x-edit-form-updates

[BrandonMorr]

What does this Pull Request do?

• Fixed issue with extra cue entry being inserted into TRANSCRIPT on page submit.

• Updated form markup, removed unneeded description.

• Added validation on TRANSCRIPT datastream to check if the mimetype is XML (VTT does not appear to be supported at the moment, so lets provide a message explaining this).

• Refactored code, removed unused variables/module includes, updated comments.

How should this be tested?

Before pulling down the changes:

• Ingest an OH object with an XML based transcript.
• On the object view page, bring up the edit transcript form.
• You'll notice that there is an empty cue at the end of the form, click submit and you'll see PHP error be thrown.
• Reload the page, now you'll notice there's a fair bit of warnings on the page because there is now an empty element in your transcript datastream.

Pull down the changes, and run through the test case again with a new OH object.

• The form should properly submit and properly update the transcript datastream with the edits 🙂.

Interested parties

@MarcusBarnes

[MarcusBarnes]

@BrandonMorr Thanks so much. I'll review and test.

[BrandonMorr]

No problem! Thanks for the quick response.

[MarcusBarnes]

FYI - The Travis build is failing because there are some issues with PEAR and Travis CI, resulting in Islandora not installing properly. Our Travis CI testing is based off the one used for core Islandora module testing. Once the issue is addressed there, we will update our Travis CI setup for testing this module.

[BrandonMorr]

Good to know, thanks for the heads up.

[MarcusBarnes]

@BrandonMorr I've tested and works as described. Thank you for your pull-request. Great work.

[BrandonMorr]

Thanks Marcus! Cheers 🎉