search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

VTTConverter mishandling certain cue timestamps #137

Closed MarcusBarnes closed 5 years ago

MarcusBarnes commented 5 years ago

As reported to the Islandora Google Group by Tony Kurtz and initially investigated by @DiegoPino: https://groups.google.com/forum/#!msg/islandora/WVRpkJL_2sk/MnDcm7wIHAAJ It appears that certain timestamps that appear valid are mishandled by VTTConverter.php. Please confirm the reported behaviour and provide a fix as appropriate.

MarcusBarnes commented 5 years ago

Reported behaviour confirmed.

MarcusBarnes commented 5 years ago

Addressed in pull-request https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/pull/141 (merged with commit https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/commit/dbb05a36551f91f48ddbe25b4acb999173499020).