search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Safer iteration on the TRANSCRIPT xml data #140

Closed BrandonMorr closed 5 years ago

BrandonMorr commented 5 years ago

What does this Pull Request do?

Introduces safer iteration when reading from the XML data to build the TRANSCRIPT edit form.

What's new?

--for ++ foreach

How should this be tested?

Ingest a test OH object with an XML based TRANSCRIPT datastream. Edit the datastream contents with the edit form and ensure that each cue has it's own fieldset and that your edits properly save when you submit the form.

I tested this with a single cue TRANSCRIPT and a multi-tiered TRANSCRIPT, both of which properly loaded/saved.

Interested parties

@MarcusBarnes @Natkeeran

MarcusBarnes commented 5 years ago

@BrandonMorr Thanks for this. Looks good.