search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

add classes to array for later use #146

Closed nhart closed 5 years ago

nhart commented 5 years ago

What does this Pull Request do?

PHP 7+ complains about un-supported type https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/blob/7.x/transcripts_ui/theme/transcripts_ui.theme.inc#L51-L52 https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/blob/7.x/transcripts_ui/theme/transcripts_ui.theme.inc#L66-L67

What's new?

Set default empty array for later use in theme process.

How should this be tested?

View a OH object with transcript display enabled with PHP7+. Prior to PR, Drupal will white screen and with PR you can view object.

Interested parties

@MarcusBarnes

MarcusBarnes commented 5 years ago

Related issue https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/issues/144. FYI - we are in the process of updating our Travis builds and this sort of thing should be detected in the future. Thanks!

MarcusBarnes commented 5 years ago

N.B. - It is worthwhile smoke testing and merging this pull-request and the expected pull-request for issue #144 even before the remaining issues with the Travis builds are sorted out. Self assigning.

nhart commented 5 years ago

Any update on this @MarcusBarnes ?

MarcusBarnes commented 5 years ago

@nhart I'm going to merged your suggested changes. There are still some issues with the Travis build that need to be sorted out. Once the Travis build is sorted out, we'll be able to catch issues like this automatically. Thanks!

MarcusBarnes commented 5 years ago

@nhart Thank you for your contribution.