Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Add aria-label attribute to tier-selector to fix accessibility error #149

Closed patdunlavey closed 4 years ago

patdunlavey commented 4 years ago

What does this Pull Request do?

Adds an area-label attribute to the language and speaker selector. This is the only error identified by the Web AIM accessibility checker for the transcript user interface.

How should this be tested?

Use the WAVE chrome extension to view an oral history object with a transcription present. Prior to applying this change, a "missing form label" error is flagged on the select element identified by data-header="Select languages"

After applying this code change and re-running the accessibility test on this page, the accessibility error disappears.

Additional Notes:

Does the aria-label "Transcript language and speaker selector" make sense?

Interested parties

@Natkeeran @MarcusBarnes

MarcusBarnes commented 4 years ago

@patdunlavey I really like this. Thank you. The Travis failure is not related to your code. We have to update our Travis checks for this repo. I'll test next week, but as this is a small change, I expect we can proceed with merging after the test.

MarcusBarnes commented 4 years ago

Thanks again @patdunlavey for your contribution. Much appreciated.