search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Hide the transcript viewer if no transcript is available #78

Closed MarcusBarnes closed 7 years ago

MarcusBarnes commented 7 years ago

Hide the transcript viewer if no transcript is available - addresses issue #73.

What does this Pull Request do?

Adds some additional logic to hide the transcript viewer in the theme files for the case when there is no transcript associated with an oral history object.

What's new?

Hides the transcript view region associated with an oral history object when there is no transcript.

How should this be tested?

Clear your Drupal cache after pulling the code changes:

  1. Create an oral history object with a transcript (XML or WebVTT). Assuming that the ingest is successful, you should see the transcript tab as usual.
  2. Create an oral history object (video or audio) without adding a transcript (XML or WebVTT). You should not see the transcript viewer area.

Additional Notes:

For deployments where there is a need to indicate that an object is an oral history object and that a transcript is not currently available, the theme files may need to be adjusted to indicate this rather than hiding the transcript viewer completely. If this becomes a need, this can be implemented as additional configuration options (rather than having deployments hack the theme files).

Interested parties

@kimpham54

Natkeeran commented 7 years ago

Works as described for me.

kimpham54 commented 7 years ago

thanks @MarcusBarnes ++