Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface

GNU General Public License v3.0

13 stars 23 forks source link

use transcript xml file name to determine the language code of the de… #88

Closed Natkeeran closed 7 years ago

Natkeeran commented 7 years ago

What does this Pull Request do?

Addresses this issue: https://github.com/digitalutsc/islandora_solution_pack_oralhistories/issues/70

Implements @kimpham54 suggestion to use transcript file name to set the default file name of the webvtt derivative.

What's new?

MEDIATRACK will have language suffix appended to indicate the default language. If transcript xml does not have any _language, will default to en (English).

How should this be tested?

Get PR
Upload a transcript xml with file name with language such as test_fr.xml
Verify that MEDIATRACK derivative takes that language suffix
Verify that Closed Caption displays that language option and if that language is one of the default values, it shows the CC by default

MarcusBarnes commented 7 years ago

Tested and appears to work as expected. Thank you @Natkeeran.