Islandora / Alpaca

Event driven middleware based on Apache Camel for Islandora
http://islandora.ca
MIT License
7 stars 20 forks source link

Deploy snapshot builds with travisci #45

Closed jonathangreen closed 7 years ago

jonathangreen commented 7 years ago

GitHub Issue

https://github.com/Islandora-CLAW/CLAW/issues/713

What does this Pull Request do?

How should this be tested?

Make sure travis passes.

Interested parties

@dannylamb

dannylamb commented 7 years ago

@jonathangreen Ah yeah... the history on that weird setup was that it would be for end to end integration tests, but that's on hold until we sort out A LOT of stuff. It's not so easy because we use so many different languages and technologies, no one framework is really gonna do it for us.

codecov[bot] commented 7 years ago

Codecov Report

Merging #45 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #45   +/-   ##
=========================================
  Coverage     91.74%   91.74%           
  Complexity       58       58           
=========================================
  Files             8        8           
  Lines           666      666           
  Branches          3        3           
=========================================
  Hits            611      611           
  Misses           52       52           
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ea125c...6ce1a36. Read the comment docs.

whikloj commented 7 years ago

@jonathangreen does this deploy on any commit or only tagged ones?

jonathangreen commented 7 years ago

@dannylamb Okay cool. I can put the .travis.yml back the way it was before if you want. It just seemed really ... weird to have a travis java build set to use PHP.

@whikloj It deploys snapshots for any commit that hits the master branch.

dannylamb commented 7 years ago

@jonathangreen Nah, don't bother. We need this Travis to just run the Alpaca tests and we'll figure out the rest later. We've got it in history.

whikloj commented 7 years ago

@jonathangreen I have no objections to this. 👍

dannylamb commented 7 years ago

Let's roll the dice and see what happens.