search

Islandora / Alpaca

Event driven middleware based on Apache Camel for Islandora
http://islandora.ca
MIT License
7 stars 20 forks source link

Reworking fcrepo indexer to be file system aware #51

Closed dannylamb closed 6 years ago

dannylamb commented 6 years ago

GitHub Issue: Part of https://github.com/Islandora-CLAW/CLAW/issues/769

What does this Pull Request do?

Updates islandora-indexing-fcrepo to handle the new message format, and deposits derivatives in the filesystem selected through the Drupal UI. Don't mind all the POJO boilerplate.

How should this be tested?

Test as part of https://github.com/Islandora-CLAW/islandora/pull/92

Additional Notes:

Needs tests, just putting this out there before wrapping it all up.

Interested parties

@Islandora-CLAW/committers

codecov[bot] commented 6 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.88%. The diff coverage is 85.49%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #51      +/-   ##
============================================
+ Coverage     79.47%   80.36%   +0.88%     
- Complexity       56       93      +37     
============================================
  Files            11       17       +6     
  Lines           229      331     +102     
  Branches          1        1              
============================================
+ Hits            182      266      +84     
- Misses           46       64      +18     
  Partials          1        1
Impacted Files Coverage Δ Complexity Δ
...ca/indexing/fcrepo/event/AS2AttachmentContent.java 100% <100%> (ø) 5 <5> (?)
...lpaca/indexing/triplestore/TriplestoreIndexer.java 100% <100%> (ø) 6 <0> (ø) :arrow_down:
.../connector/houdini/event/AS2AttachmentContent.java 100% <100%> (ø) 11 <2> (ø) :arrow_down:
...ora/alpaca/connector/houdini/HoudiniConnector.java 100% <100%> (ø) 3 <0> (ø) :arrow_down:
...landora/alpaca/indexing/fcrepo/event/AS2Actor.java 70% <70%> (ø) 4 <4> (?)
...andora/alpaca/indexing/fcrepo/event/AS2Object.java 70% <70%> (ø) 5 <5> (?)
...islandora/alpaca/indexing/fcrepo/event/AS2Url.java 75% <75%> (ø) 7 <7> (?)
...landora/alpaca/indexing/fcrepo/event/AS2Event.java 78.94% <78.94%> (ø) 9 <9> (?)
...ra/alpaca/indexing/fcrepo/event/AS2Attachment.java 80% <80%> (ø) 5 <5> (?)
...slandora/alpaca/indexing/fcrepo/FcrepoIndexer.java 90.24% <94.44%> (+2%) 6 <3> (+2) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8daf703...9a5d206. Read the comment docs.

whikloj commented 6 years ago

@DiegoPino can I merge this, I think your requests have been addressed.

DiegoPino commented 6 years ago

@whikloj i did not get to test all the code, but my concerns are addressed, feel free to merge, you know the internals way better