search

Islandora / Crayfish

A collection of Islandora microservices, lovingly known as Crayfish.
MIT License
9 stars 29 forks source link

Update symfony/flex. #144

Closed jordandukart closed 2 years ago

jordandukart commented 2 years ago

GitHub Issue: https://github.com/Islandora/documentation/issues/2079

What does this Pull Request do?

Updates symfony/flex that's required due to an end-of-life of their previous download manager.

What's new?

Version bump.

How should this be tested?

Houdini should still operate as expected.

Interested parties

@alxp

codecov[bot] commented 2 years ago

Codecov Report

Merging #144 (ac852df) into 2.x (75ddd81) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x     #144   +/-   ##
=========================================
  Coverage     76.60%   76.60%           
  Complexity      161      161           
=========================================
  Files             6        6           
  Lines           654      654           
=========================================
  Hits            501      501           
  Misses          153      153

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75ddd81...ac852df. Read the comment docs.

alxp commented 2 years ago

Still seem to be getting the same error on composer install and also update:

vagrant@islandora8:/var/www/html/Crayfish/Houdini$ composer install
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.

In PackageFilter.php line 125:

  Undefined index: splits  

install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]

vagrant@islandora8:/var/www/html/Crayfish/Houdini$ git branch
  2.x
* 2.x-ISLANDORA-2079
  dev
vagrant@islandora8:/var/www/html/Crayfish/Houdini$
alxp commented 2 years ago

The GitHub page referencing this error mentions that symfony/flex should be at least version 1.17.

On this PR's branch it's at 1.13.

$ composer info symfony/flex
name     : symfony/flex
descrip. : Composer plugin for Symfony
keywords : 
versions : * v1.13.3
type     : composer-plugin
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
homepage : 
source   : [git] https://github.com/symfony/flex.git 2597d0dda8042c43eed44a9cd07236b897e427d7
dist     : [zip] https://api.github.com/repos/symfony/flex/zipball/2597d0dda8042c43eed44a9cd07236b897e427d7
jordandukart commented 2 years ago

Thanks for catching @alxp derped on composer update versus composer require.

alxp commented 2 years ago

Updated and tested on fresh Playbook install.

Was able to see Service File mp4, so this update does not seem break Crayfish's functionality.

image