Closed ysuarez closed 2 years ago
Merging #145 (a51560d) into 2.x (0a54c76) will decrease coverage by
0.95%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## 2.x #145 +/- ##
============================================
- Coverage 77.55% 76.60% -0.96%
- Complexity 159 161 +2
============================================
Files 6 6
Lines 655 654 -1
============================================
- Hits 508 501 -7
- Misses 147 153 +6
Impacted Files | Coverage Δ | |
---|---|---|
...dir/Milliner/src/Controller/MillinerController.php | 95.40% <0.00%> (-4.60%) |
:arrow_down: |
build_dir/Milliner/src/Service/MillinerService.php | 70.58% <0.00%> (-0.42%) |
:arrow_down: |
...d_dir/Houdini/src/Controller/HoudiniController.php | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0a54c76...a51560d. Read the comment docs.
GitHub Issue: https://github.com/Islandora/documentation/issues/2074
What does this Pull Request do?
This PR adds a variable for better support for Fedora 6, by helping the Milliner configuration realize that it will be working with Fedora 6. The PR also adds a small update to the README to explain the small code change. It also removes some trailing spaces found in the config file.
What's new?
fcrepo6: true
to Milliner/cfg/config.example.yaml, that needs to be uncommented if using Fedora 6.How should this be tested?
@seth-shaw-unlv may be better at explaining this, but I suspect you must create a Islandora 2 instance with Fedora 6 after you set
fcrepo6: true
and perform some Fedora 6 operations to see the PR work correctly.Interested parties
@Islandora/8-x-committers