Islandora / Crayfish

A collection of Islandora microservices, lovingly known as Crayfish.
MIT License
9 stars 29 forks source link

Upgrade symfony to 5.4 & separate EntityMapper #174

Closed whikloj closed 1 year ago

whikloj commented 1 year ago

GitHub Issue: https://github.com/Islandora/documentation/issues/2220

Relies on

  1. https://github.com/Islandora/chullo/pull/99
  2. https://github.com/Islandora/Crayfish-Commons/pull/63

What does this Pull Request do?

What's new?

How should this be tested?

See the full build PR on islandora-playbook here (https://github.com/Islandora-Devops/islandora-playbook/pull/263)

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.21 :warning:

Comparison is base (d4bc375) 76.93% compared to head (bafdd3b) 76.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.x #174 +/- ## ============================================ - Coverage 76.93% 76.72% -0.21% Complexity 160 160 ============================================ Files 6 6 Lines 711 782 +71 ============================================ + Hits 547 600 +53 - Misses 164 182 +18 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/Islandora/Crayfish/pull/174/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Islandora)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

whikloj commented 1 year ago

Thinking about this I decided to make a new 4.x branch as this changes the version of Symfony and as such would not be a simple overlay. It will require changes to your configuration which I may have to write.