Islandora / Crayfish

A collection of Islandora microservices, lovingly known as Crayfish.
MIT License
9 stars 29 forks source link

Passthrough the configured MIME. #175

Closed jordandukart closed 1 year ago

jordandukart commented 1 year ago

What does this Pull Request do?

Allows a configured MIME type from an Islandora action to be passed through to Hypercube.

What's new?

The MIME type of text/plain is no longer hardcoded and a configured MIME type is now used.

How should this be tested?

Create an action that uses Hypercube (OCR, hOCR) and specify a MIME type that isn't text/plain.

Ingest an object and media that will create a derivative with Hypercube to be triggered (for example a book, pages and media).

The resultant File entities within Drupal have the set MIME type that matches the one configured.

Interested parties

@Islandora/8-x-committers

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c2c44b9) 76.72% compared to head (8048e5a) 76.72%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.x #175 +/- ## ========================================= Coverage 76.72% 76.72% Complexity 160 160 ========================================= Files 6 6 Lines 782 782 ========================================= Hits 600 600 Misses 182 182 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

seth-shaw-asu commented 1 year ago

So, this works as described. The only hesitation I have is that the Media entity is still showing text/plain instead of the new mime type on the file.

seth-shaw-asu commented 1 year ago

Although I suppose that is a Drupal issue; not a Crayfish one...