Islandora / chullo

Chullo is a PHP client for Fedora 5 built using Guzzle and EasyRdf.

https://packagist.org/packages/islandora/chullo

MIT License

6 stars 17 forks source link

only alias the class if it doesn't exist? #93

Closed elizoller closed 3 years ago

elizoller commented 3 years ago

GitHub Issue: (https://github.com/Islandora/documentation/issues/1759)

What does this Pull Request do?

Removes an annoying warning

What's new?

before creating the alias for the class, check if that class already exists

How should this be tested?

pull in PR (in the vendor directory) and make sure islandora can still talk to chullo
make sure no more PHP warning when doing drush cr

Interested parties

@Islandora/8-x-committers @mjordan @jqi26

mjordan commented 3 years ago

@elizoller I'll test this evening. What's the easiest way to make sure islandora can still talk to chullo?

elizoller commented 3 years ago

chullo is the library that speaks Fedora API so i would test any communication with fedora like creating an item and making sure it ends up in fedora.

mjordan commented 3 years ago

@elizoller PHP warning during drush cr is gone, but when I create a node, it isn't pushed to Fedora. Drupal can still read objects existing in Fedora and updates to existing objects also still work.

Any suggestions on how I can debug creating new objects?

elizoller commented 3 years ago

@mjordan you could look to see if there is anything in any of the logs (drupal, karaf) about things failing. what is your environment like again - php version, drupal version?

mjordan commented 3 years ago

Sorry, this does work. Nodes and media are created, and the Drush warning is gone. Drupal 8.9.12-dev / PHP 7.4.13. Drupal and Karaf logs are clean.

I can merge this unless anyone else wants to test.

dannylamb commented 3 years ago

I vote merge ^_^