Islandora / controlled_access_terms

Drupal module for subject and agents
GNU General Public License v2.0
7 stars 28 forks source link

[BUG] Updated config format #117

Open joecorall opened 2 months ago

joecorall commented 2 months ago

We need to update config values for all solr year processors for sites that had the old setting before https://github.com/Islandora/controlled_access_terms/pull/113 was merged

We need a hook_update_N in this module to append node to all solr indexes that have an edtf year processor set but are of the format bundle|field and not entity_type|bundle|field

diff --git a/config/sync/search_api.index.default_solr_index.yml b/config/sync/search_api.index.default_solr_index.yml
index 1ea2baaa..48cf7988 100644
--- a/config/sync/search_api.index.default_solr_index.yml
+++ b/config/sync/search_api.index.default_solr_index.yml
@@ -482,10 +482,10 @@ processor_settings:
   custom_value: {  }
   edtf_year_only:
     fields:
-      islandora_object|field_copyright_date: islandora_object|field_copyright_date
-      islandora_object|field_edtf_date: islandora_object|field_edtf_date
-      islandora_object|field_edtf_date_created: islandora_object|field_edtf_date_created
-      islandora_object|field_edtf_date_issued: islandora_object|field_edtf_date_issued
+      node|islandora_object|field_copyright_date: node|islandora_object|field_copyright_date
+      node|islandora_object|field_edtf_date: node|islandora_object|field_edtf_date
+      node|islandora_object|field_edtf_date_created: node|islandora_object|field_edtf_date_created
+      node|islandora_object|field_edtf_date_issued: node|islandora_object|field_edtf_date_issued
     ignore_undated: 1
     ignore_open_start: 0
     open_start_year: '0'
rosiel commented 3 weeks ago

@joecorall is this good to close?

joecorall commented 3 weeks ago

Looking at the usage chart on drupal.org, quite a few people are still on 2.2, and they would benefit from a hook_update_N to get them on the proper format after upgrading. There also may be others that have already upgraded to 2.4 that would benefit, too, (i.e. their EDTF date solr search may be degraded).

jordandukart commented 2 weeks ago

Discussed this on June 19th tech call, this should be implemented given that it was a backwards breaking change.