seth-shaw-asu
commented
3 weeks ago Looks nice.
I'm wondering if the Authority Link would be better as a link superimposed over the Selection list icon; since it is essentially a link field combined with a selection list field.
rosiel
GitHub Issue: none
Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.): Previously mentioned in a Tech Call.
What does this Pull Request do?
Make the Add Field interface pretty for these field types.
What's new?
Use the new Drupal 10.2 Field Type API -- this is why it's draft, until we can drop 10.1 - to define our Typed Relation as a category. Now it works like the Reference field, where you select a category then select a sub-type.
Added three SVG icons for our fields, based off the icons of the field types they're based on.
Added a library to add those CSS classes
Did a hook form alter to add our CSS library to the form. (I declined to use the Form Alter As Plugin module, though it seems cool.)
Does this change require documentation to be updated? - Maybe screenshots, when we get the rest of our weird fields prettified.
Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no
How should this be tested?
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers