Islandora / controlled_access_terms

Drupal module for subject and agents
GNU General Public License v2.0
7 stars 30 forks source link

Added form and view for authority link in resource types taxonomy #51

Closed bseeger closed 4 years ago

bseeger commented 4 years ago

GitHub Issue: https://github.com/Islandora/documentation/issues/1499

What does this Pull Request do?

Completes the entity view and form view for the Resource Type taxonomy. This also cleans up the resource_types taxonomy a little in making it use the existing field_authority_link, rather then field_external_authority_link as it was doing. (this was done at the request of @seth-shaw-unlv and removes the need for the extra not-really-needed field and subsequent db table).

@seth-shaw-unlv - how does this look? I tried it and got the expected form setup now, though I do wonder if langcode, translation, and path should be in the form file.

When I did run this the first time the external authority link field was empty - which I suspect would be expected since the form was wrong before? Ie, there were defaults, but since the form wasn't set the defaults didn't get set? When I added data to the external authority link field, it did stick around as expected.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers