Remove dependency on Name module.

[rosiel]

GitHub Issue: https://github.com/Islandora/documentation/issues/1561 (tangentially, as removing "Name" is something that's come up in discussion multiple times but this seems to be the first place in the issue queue I can find it documented, though it doesn't solve that issue, which is about how/why we would parse out names to parts without being harmful with it)

Other Relevant Links

• https://github.com/Islandora/documentation/issues/815 (as in, it touches on how we handle 'local authorities')

What does this Pull Request do?

Replaces the two Name-type fields (Preferred Name and Alternate Names) with one Alternate Name text-type field.

What's new?

    modified:   core.entity_form_display.taxonomy_term.person.default.yml
    modified:   core.entity_view_display.taxonomy_term.person.default.yml
    new file:   field.field.taxonomy_term.person.field_alternate_name.yml
    deleted:    field.field.taxonomy_term.person.field_person_alternate_names.yml
    deleted:    field.field.taxonomy_term.person.field_person_preferred_name.yml
    new file:   field.storage.taxonomy_term.field_alternate_name.yml
    deleted:    field.storage.taxonomy_term.field_person_alternate_names.yml
    deleted:    field.storage.taxonomy_term.field_person_preferred_name.yml
    modified:   rdf.mapping.taxonomy_term.person.yml
    modified:   taxonomy.vocabulary.person.yml
    modified:   ../../controlled_access_terms_defaults.info.yml

[and then went back and fixed README.md and controlled_access_terms.info.yml]

Note: I did this manually, based on my in-depth knowledge of how fields, field storage, form display, view display, rdf mapping, vocabularies, and features work together. Since it was manual, there are probably errors, but this was the only way to avoid including a LOT of changes in the diff that have nothing to do with what I'm trying to accomplish. (content and status appearing in form displays; search_api_excerpt in the entity view displays,...) which happened when I followed this procedure:

• spin up a fresh islandora_vagrant
• edit the config to how i want it
• Go to the Features page and export the feature (required me to select 'allow conflicts' first)
• used diff to compare that folder line-by-line with what was in the modules/ folder of a fresh git clone of this repo.

How should this be tested?

I have no idea how to test this! (there should be documentation)

Additional Notes:

Editing the config in my local Drupal took under 5 minutes. Creating this pull request has taken 95 minutes. (there should be documentation)

Interested parties

@Islandora/8-x-committers

[seth-shaw-unlv]

Superseded by https://github.com/Islandora/controlled_access_terms/pull/54.