Islandora / controlled_access_terms

Drupal module for subject and agents
GNU General Public License v2.0
7 stars 28 forks source link

More schema definition fun. #85

Closed adam-vessey closed 1 year ago

adam-vessey commented 1 year ago

GitHub Issue: https://github.com/Islandora/documentation/issues/2164

What does this Pull Request do?

Fleshes out config schema.

What's new?

A number of new config schemas being defined. Later exports may end up changing the types of values stored in exported YAML; for example: If something is now defined as a boolean, it should now be exported as a true or false whereas before it would've likely been the integers 1 or 0... shouldn't really have any effect, just might cause a bit of noise in diffs as it happens.

How should this be tested?

  1. Install and enable the config_inspector module
  2. Either:

    1. Run:
      drush config:inspect --only-error --detail

      or:

      1. Looks at the reports at /admin/reports/config-inspector

    to note the number of config errors present from the plugins defined in Islandora.

  3. Grab the code
  4. Clear cache
  5. Re-run/Look at the config_inspector output, and see that the number of errors should be reduced.

Documentation Status

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers