search

Islandora / documentation

Contains islandora's documentation and main issue queue.
MIT License
103 stars 71 forks source link

Replacement for Islandora IP Embargo #1160

Open mjordan opened 5 years ago

mjordan commented 5 years ago

We need a way to restrict access to Islandora 8 content (nodes and media) by IP address. This functionality is currently provided within Islandora 7.x sites using Islandora IP Embargo.

mjordan commented 5 years ago

I couldn't find anything in the Drupal contrib world that provides IP-based access to content, so I've started a simple module to do that. It uses Context, so site builders can combine IP access with collection membership, migrated 7.x namespaces, tags, etc.

https://github.com/mjordan/ip_range_access

Would love some testing and feedback!

dannylamb commented 5 years ago

Couple of things I noticed just checking the code (no testing yet... would have to think through how to set up the testing scenario):

  1. Schema entries for the plugins \o/
  2. Does the context reaction for blocking access even need a form? Seems like it should just do it, and doesn't really require the checkbox.
mjordan commented 5 years ago

@dannylamb thanks. I have an issue, and a fix, for 1, just haven't pushed it up yet.

For 2, you're right, it doesn't, I have that there in anticipation of https://github.com/mjordan/ip_range_access/issues/2.

I'm still making sure that the "Negate the condition" logic works. I'll try for a bit more, but I'd appreciate a second set of eyes on it

rosiel commented 2 years ago

"IP Authentication" was listed as an area of concern on the ICG Report on Systems Testing.