search

Islandora / documentation

Contains islandora's documentation and main issue queue.
MIT License
104 stars 71 forks source link

Binding with fedora #1532

Open adam-vessey opened 4 years ago

adam-vessey commented 4 years ago

In https://github.com/Islandora/islandora/pull/742, explicit references to configuration of Fedora in were made in code, causing warnings should a system be setup and configured without it.

adam-vessey commented 4 years ago

Discussed during the 2020-09-02 I8 tech call. @elizoller pointed out the use of the set property in https://github.com/Islandora/Alpaca/blob/f4af9b97475cf2b64822836be6f65a7453b537c1/islandora-indexing-fcrepo/src/main/java/ca/islandora/alpaca/indexing/fcrepo/FcrepoIndexer.java#L152

Discussion seemed to indicate that an isset() check around the access should be sufficient, with anything downstream which expects the value to be there should be made to deal with its existence.

jordandukart commented 3 years ago

This has popped in the D9 sprint as PHP 7.4 now throws warnings when encountering this: https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.non-array-access.