search

Islandora / documentation

Contains islandora's documentation and main issue queue.
MIT License
104 stars 71 forks source link

[TECH DEBT] Crayfish controllers hardcode parameters #2169

Open jordandukart opened 2 years ago

jordandukart commented 2 years ago

Overview of feature request Crayfish controllers hardcode parameters on commands examples: https://github.com/Islandora/Crayfish/blob/0a4e8d2b546f47f33c1a22f1a1ed1a3293e2f838/Houdini/src/Controller/HoudiniController.php#L121-125 and https://github.com/Islandora/Crayfish/blob/0a4e8d2b546f47f33c1a22f1a1ed1a3293e2f838/Homarus/src/Controller/HomarusController.php#L117.

Moving this to be completely controlled by the header allows greater flexibility.

What kind of user is the feature intended for? Developer

What inspired the request? https://github.com/Islandora/Crayfish/pull/162/files

What existing behavior do you want changed? Hardcoding parameters to commands is inflexible.

whikloj commented 2 years ago

This makes sense. But then so does https://github.com/Islandora/Crayfish/pull/133

whikloj commented 2 years ago

Looking in to this, I'm wondering about the Houdini example. That one is modifying the STDIN argument for ImageMagick from - to pid:-[0].

We don't pass in this type of information for other microservices, so I am wondering if we want to start now?

The Homarus one is fine with me though.