[BUG] Islandora IIIF PHP warnings

[kayakr]

What steps does it take to reproduce the issue? When using Islandora IIIF module to provide a manifest for Mirador, I get PHP warnings:

• Warning: Undefined array key "structured_text_term_uri" in Drupal\islandora_iiif\Plugin\views\style\IIIFManifest->getStructuredTextTerm() (line 630 of /app/web/modules/contrib/islandora/modules/islandora_iiif/src/Plugin/views/style/IIIFManifest.php)
• Warning: Undefined array key "search_endpoint" in Drupal\islandora_iiif\Plugin\views\style\IIIFManifest->addSearchEndpoint() (line 497 of /app/web/modules/contrib/islandora/modules/islandora_iiif/src/Plugin/views/style/IIIFManifest.php) fixed in Islandora 2.12.3
• Deprecated function: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\islandora_iiif\Plugin\views\style\IIIFManifest->addSearchEndpoint() (line 498 of /app/web/modules/contrib/islandora/modules/islandora_iiif/src/Plugin/views/style/IIIFManifest.php) fixed in Islandora 2.12.3

I am not using hOCR.

• When does this issue occur?

  1. View content via Mirador, mapped to node/%/book-manifest, when structured_text_term_uri and search_endpoint fields are null (default state).
  2. Check watchdog log.

• What happens?

  1. /admin/structure/views/view/iiif_manifest/edit/rest_export_3 Book Manifest (Original File): Style options form offers fields for "Structured OCR text term" and "Search endpoint path." - both fields are optional, but cause warnings if left null.

Which version of Islandora are you using? 2.12.2 (also reported on 2.12.3)

Which method did you use to install your Islandora instance? (manually, ISLE, playbook, etc.) ISLE / lando

Any related open or closed issues to this bug report? None found

[kayakr]

The search_endpoint warning is resolved in Islandora 2.12.3 via search_endpoint

[adam-vessey]

Suspecting something like this should do the trick, to avoid blindly attempting to use a structured_text_term_uri value that might not be present: https://github.com/Islandora/islandora/pull/1047

[alxp]

I just tested the latest 2.x branch of drupal/islandora and see no errors or warnings relating to IIIF when viewing content in a base isle-dc + starter site install.

I do see a warning related to the Article content type configuration:

row 6 Message Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies. column 2

which looks like a separate issue with the starter site.

But once we make a release that includes @adam-vessey 's PR commit the IIIF warnings should go away.

By way of mea culpa , I did not test enough on a basic starter site that didn't have everything like the search endpoint set up.

[kayakr]

@alxp FYI the "Message Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies" is likely arising from a core issue https://www.drupal.org/node/3306434