Islandora / islandora

Drupal modules for browsing and managing digital repositories.
http://islandora.ca/
GNU General Public License v2.0
152 stars 118 forks source link

Node has Parent context does not explicitly check if the field exists. #1018

Closed bibliophileaxe closed 6 months ago

bibliophileaxe commented 6 months ago

What steps does it take to reproduce the issue?

What happens? WSOD

What did you expect to happen? The content gets created

Which version of Islandora are you using? 2.0

Fix https://github.com/Islandora/islandora/blob/3902cce0ac7525aa209e56f198d5059f4c42e09a/src/Plugin/Condition/NodeHasParent.php#L141

Should check whether field exists.

Another small win: https://github.com/Islandora/islandora/blob/3902cce0ac7525aa209e56f198d5059f4c42e09a/src/IslandoraContextManager.php#L40

Disabled check should happen before the evaluation of context conditions.

Screenshots:

image image