Islandora / islandora

Drupal modules for browsing and managing digital repositories.
http://islandora.ca/
GNU General Public License v2.0
152 stars 118 forks source link

added check #1031

Closed ajstanley closed 4 months ago

ajstanley commented 4 months ago

*Issue 1030: (link)

What does this Pull Request do?

If an Islandora installation does not use Fedora then viewing a media object will cause a fatal error

What's new?

A check for $fedora_root has been added to islandora_entity_view

How should this be tested?

Delete or comment out the flysystem config from settings.php, then try to view a media

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

@Islandora/committers

adam-vessey commented 4 months ago

Shouldn't the display not be defining field_gemini_uri, if Fedora's not in use? https://github.com/Islandora/islandora/pull/1031/files#diff-9f1c9d46d88dce55fa1d0ce1103dd4184b824342407a63c2397844703c09b78eR548

rosiel commented 4 months ago

from Tech call: