islandora#1059: HTTP error 500 on /media/:mid?_format=jsonld if Media lacks File

[xurizaemon]

GitHub Issue: #1059

What does this Pull Request do?

Prevent a (not user facing) error when a Media lacks an associated File and /media/123456?_format=jsonld is requested for the Media item.

Instead of trying to return an @id with the File URI, we return the existing @id which has come from the Media entity.

What's new?

• When no file is attached and $file is FALSE, do not overwrite the JSON @id value with the file URL
• Media will then use the Media's URL

How should this be tested?

Before patch:

1. Create a Media entity which has no File attached
2. Request /media/123456?_format=jsonld for that file
3. See error in Drupal logs

After patch:

2. Request /media/123456?_format=jsonld for that file
3. See no error in Drupal logs

Documentation Status

• Does this change existing behaviour that's currently documented? NO
• Does this change require new pages or sections of documentation? NO
• Who does this need to be documented for? nobody?
• Associated documentation pull request(s): or documentation issue

Additional Notes:

Interested parties

CC @seth-shaw-asu @Islandora/committers

[seth-shaw-asu]

Is this still a draft or is it ready to test?

[xurizaemon]

I think it's good to test @seth-shaw-asu - thanks!