search

Islandora / islandora_ci

MIT License
0 stars 4 forks source link

Allow multiple drupal #6

Closed whikloj closed 3 years ago

whikloj commented 3 years ago

@Islandora/8-x-committers this should have no effect on current builds but will enable multiple Drupal version testing ala https://github.com/Islandora/islandora/pull/821

whikloj commented 3 years ago

No, https://github.com/Islandora/islandora/pull/821 passed because islandora_ci can only run 8.9.11. It just ran it 6 times instead of 3.

whikloj commented 3 years ago

Before I opened the draft pr I did run a test. I can show you how to run your own tomorrow if you'd like.

elizoller commented 3 years ago

Ah ok, talk to you tomorrow then 👍

elizoller commented 3 years ago

With @whikloj 's help, i was able to test the islandora_ci change on the islandora module here: https://travis-ci.com/github/asulibraries/islandora/builds/212494945 which created 12 builds php 7.3 / drupal 8 / kernel php 7.3 / drupal 8 / functional php 7.3 / drupal 8 / functional-javascript php 7.3 / drupal 9 / kernel php 7.3 / drupal 9 / functional php 7.3 / drupal 9 / functional-javascript php 7.4 / drupal 8 / kernel php 7.4 / drupal 8 / functional php 7.4 / drupal 8 / functional-javascript php 7.4 / drupal 9 / kernel php 7.4 / drupal 9 / functional php 7.4 / drupal 9 / functional-javascript

verified that the correct PHP version and drupal version was installed so i think this is good to go