Islandora / islandora_mirador

Use the Mirador viewer with your Islandora site.
https://www.drupal.org/project/islandora_mirador
GNU General Public License v2.0
3 stars 10 forks source link

[BUG] `hook_install()` term creation failures during site installation from `--existing-config` #13

Closed adam-vessey closed 1 year ago

adam-vessey commented 1 year ago

What steps does it take to reproduce the issue?

Site installation using an --existing-config, with this module enabled.

N/A

Don't recall the exact error, but it will attempt to create the term before the islandora_display taxonomy itself is configured, due to the site installation flow (was encountered previously with islandora_fits when dealing with the islandora-starter-site):

... looking back at https://github.com/roblib/islandora_fits/issues/12 , I'm not sure there's an explicit error, but just that the term will probably not carry the intended value for field_external_uri, but will instead be left blank.

Sys admin.

The term to be able to be created without error.

Which version of Islandora are you using?

N/A

Any related open or closed issues to this bug report?

Same class of issue as https://github.com/roblib/islandora_fits/pull/14

Screenshots:

rosiel commented 1 year ago

I prefer (and seemed to have convinced others?) that we should take all the default config stuff including this term out, and put it in the Starter Site.