Islandora / islandora_mirador

Use the Mirador viewer with your Islandora site.
https://www.drupal.org/project/islandora_mirador
GNU General Public License v2.0
3 stars 10 forks source link

Make the mirador config more easily alterable, Drupal-side. #22

Closed adam-vessey closed 1 year ago

adam-vessey commented 1 year ago

What does this Pull Request do?

Moves building up the "object" of Mirador viewer config PHP-side, so we can alter/adjust/augment it more easily, minimizing the size of the actual Javascript "integration" piece required.

What's new?

A in-depth description of the changes made by this PR. Technical details and possible side effects.

How should this be tested?

A description of what steps someone could take to:

Documentation Status

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

jordandukart commented 1 year ago

This looks fine here to me but given the in-flight work being undertook in the community I am hesitant to merge this prior to having more sets of eyes on this, primarily in regards to the roblib integration pull and the changing of the attached structure (albeit it's backwards compatability).

alxp commented 1 year ago

Just noticed that this was no longer marked as Draft.

I tested it and the plugins and everything still works as expected so this looks good.