Islandora / islandora_mirador

Use the Mirador viewer with your Islandora site.
https://www.drupal.org/project/islandora_mirador
GNU General Public License v2.0
3 stars 9 forks source link

Issue #27: Drupal 10 compatibility. #28

Closed alxp closed 1 year ago

alxp commented 1 year ago

GitHub Issue: https://github.com/Islandora/islandora_mirador/issues/27

What does this Pull Request do?

Drupal 10 compatibility fixes.

What's new?

A in-depth description of the changes made by this PR. Technical details and possible side effects.

Fix errors reported by Upgrade Status module.

How should this be tested?

Enable the module on a Drupal 10 site. Note that as of the creation of this PR, the Islandora d10 compatibility fix PR is still open so you may still need to check that branch out also.

Go to the Islandora Mirador Administration page and ensure settings can be altered and saved.

Check that Mirador functions as it does on an Islandora site running on Drupal 9.

Documentation Status

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

rosiel commented 1 year ago

I'm approving. The use here of accessCheck(FALSE) makes far more sense than the status-quo alternative.