Islandora / islandora_mirador

Use the Mirador viewer with your Islandora site.

https://www.drupal.org/project/islandora_mirador

GNU General Public License v2.0

3 stars 10 forks source link

Move entity view displays to optional configs #9

Closed alxp closed 2 years ago

alxp commented 2 years ago

What does this Pull Request do?

Move some configs to 'optional' as they are for entity view displays defined in islandora_defaults.

What's new?

Does this change add any new dependencies? No
Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? No
Could this change impact execution of existing code? No

How should this be tested?

On a fresh Drupal install of any type, run

$ composer  require islandora/islandora_mirador

This shoul bring down islandora/islandora as a requirement but not islandora/islandora_defaults.

Then enable the module with Drush.

Without this patch, installation will fail due to missing dependencies.

Documentation Status

Does this change existing behaviour that's currently documented? No
Does this change require new pages or sections of documentation? No
Who does this need to be documented for? N/A
Associated documentation pull request(s): or documentation issue

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers