search

Islandora / openseadragon

Drupal Field Formatter for OpenSeadragon
https://www.drupal.org/project/openseadragon
GNU General Public License v2.0
4 stars 15 forks source link

Make path to openseadragon images protocol relative #25

Closed kayakr closed 2 years ago

kayakr commented 4 years ago

GitHub Issue: Islandora/documentation#1504

What does this Pull Request do?

We encountered mixed content warnings in the browser console as OS on an HTTPS site was requesting its navigation button images via HTTP even with X-Forwarded-Proto configured. Even though it's due to be removed (https://www.drupal.org/project/drupal/issues/2669074 ) file_url_transform_relative() fixes the issue.

What's new?

Wrap file_create_url() with file_url_transform_relative().

How should this be tested?

Visit a Repository Item page on a site served by https and observe mixed content warnings in browser console. Apply patch. Reload page and observe no mixed content warnings.

Interested parties

@Islandora/8-x-committers

elizoller commented 4 years ago

this might be superceded by https://github.com/Islandora/openseadragon/pull/26