Islandora / openseadragon

Drupal Field Formatter for OpenSeadragon
https://www.drupal.org/project/openseadragon
GNU General Public License v2.0
4 stars 15 forks source link

Issue-1572: Support multiple openseadragon viewer windows #28

Closed seth-shaw-unlv closed 4 years ago

seth-shaw-unlv commented 4 years ago

GitHub Issue: https://github.com/Islandora/documentation/issues/1572

What does this Pull Request do?

Adds viewer ID key to openseadragon JS settings allowing us to have multiple open seadragon viewers on the same page.

What's new?

How should this be tested?

Interested parties

@Islandora/8-x-committers

jordandukart commented 4 years ago

Smoke tested this and it seems sound to me, causes the entries in drupalSettings to be keyed uniquely which allows n viewers to be embeded in a page where as previously values would be overwritten.

dannylamb commented 4 years ago

I consider this RTBC and am happy to merge.

dannylamb commented 4 years ago

Thanks for testing @jordandukart and @manez