search

Islandora / openseadragon

Drupal Field Formatter for OpenSeadragon
https://www.drupal.org/project/openseadragon
GNU General Public License v2.0
3 stars 15 forks source link

start of d9 support #33

Closed elizoller closed 3 years ago

elizoller commented 3 years ago

GitHub Issue: (https://github.com/Islandora/documentation/issues/1729)

What does this Pull Request do?

This is a start of d9 support

What's new?

info file change and remove deprecated url() method

How should this be tested?

make sure openseadragon still works

Additional Notes:

Interested parties

@Islandora/8-x-committers

elizoller commented 3 years ago

i'm kind of at a loss for why createFileUrl(FALSE) would return null?

jordandukart commented 3 years ago

i'm kind of at a loss for why createFileUrl(FALSE) would return null?

@elizoller, not sure what you experienced here? I tested the code on an 8 before and after the URLs I got generated were identical.

Similarly, dumping both methods out with dsms yield:

url => http://localhost:8000/_flysystem/fedora/2020-12/51451703_10156721107980661_2882884170512596992_n.jpg

createFileUrl => http://localhost:8000/_flysystem/fedora/2020-12/51451703_10156721107980661_2882884170512596992_n.jpg