Islandora / openseadragon

Drupal Field Formatter for OpenSeadragon
https://www.drupal.org/project/openseadragon
GNU General Public License v2.0
4 stars 15 forks source link

Attach the JS libraries using the preprocess and not in the template. #39

Closed jordandukart closed 3 years ago

jordandukart commented 3 years ago

GitHub Issue: https://github.com/Islandora/documentation/issues/1975

What does this Pull Request do?

Includes the JS libraries in the preprocess implementations as opposed to the template. This fixes a bug that can occur when viewing a object with the block being rendered where there are no tilesources.

What's new?

Errors don't pop in the console, libraries are attached a different way.

How should this be tested?

Can reproduce the existing bug using what's documented in https://github.com/Islandora/documentation/issues/1975. Beyond that the OSD should behave as it did before when viewing things.

Interested parties

@Islandora/8-x-committers