Islandora / openseadragon

Drupal Field Formatter for OpenSeadragon
https://www.drupal.org/project/openseadragon
GNU General Public License v2.0
4 stars 15 forks source link

Jquery once fix #48

Closed wgilling closed 1 year ago

wgilling commented 1 year ago

GitHub Issue: (link) https://github.com/Islandora/documentation/issues/2205

What does this Pull Request do?

Minor adjustment to the openseadragon javascript which connects the viewer to the underlying image resource

intended result of the PR will be and/or what problem it solves.

Prevents additional canvas elements from being shown in and below an OpenSeadragon viewer.

Technical details and possible side effects.

unknown

How should this be tested?

BEFORE this code is merged, it is important to find an islandora object with image media that will use the OpenSeadragon viewer -- which causes the doubled-canvas output. (See https://github.com/Islandora/documentation/issues/2205). I have found that this happens when a larger resolution service file JPG is uploaded for a Service File media. After the code has been merged, that same object from above should only display one canvas.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers