Islandora / openseadragon

Drupal Field Formatter for OpenSeadragon
https://www.drupal.org/project/openseadragon
GNU General Public License v2.0
3 stars 15 forks source link

Update compatibility to include Drupal 10. #49

Closed rosiel closed 1 year ago

rosiel commented 1 year ago

GitHub Issue: (link)

https://github.com/Islandora/documentation/issues/2235

What does this Pull Request do?

Makes Openseadragon Drupal 10 compatible.

What's new?

A in-depth description of the changes made by this PR. Technical details and possible side effects.

How should this be tested?

Install on Drupal 10 and give it an external Mirador URI.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

rosiel commented 1 year ago

i'll add D10 to the testing matrix first

rosiel commented 1 year ago

or after. whoops.

rosiel commented 1 year ago

I think that update c357901) should cover the deprecation notices you saw. The tests ran and I don't see any deprecation warnings in them now.