Islandora / openseadragon

Drupal Field Formatter for OpenSeadragon
https://www.drupal.org/project/openseadragon
GNU General Public License v2.0
3 stars 15 forks source link

Remove deprecated prophecy calls and MimeTypeGuesserInterface. #50

Closed rosiel closed 1 year ago

rosiel commented 1 year ago

GitHub Issue: https://github.com/Islandora/documentation/issues/2235

What does this Pull Request do?

Removes deprecated calls to prophesize() and uses of the deprecated MimeTypeGuesser. Also declares D10 compatibility.

What's new?

This should make it work in Drupal 10 as it does in Drupal 9.

How should this be tested?

Spin it up on Drupal 10 and put a valid Cantaloupe URL in the OpenSeadragon settings. Place a block and feed it a manifest (since the IIIF submodule isn't ready yet) throw a demo manifest URI in the block like https://digital.library.villanova.edu/Item/vudl:92879/Manifest . Verify it shows the content, and no messages in the logs.

Additional Notes:

The tests ran (in a D9 environment) just fine. CI will tell us about Drupal 10.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers