search

IslandzVW / halcyon

InWorldz Halcyon 3d virtual reality world simulator
BSD 3-Clause "New" or "Revised" License
21 stars 26 forks source link

Tell the ServicePointManager to support TLS1.2 #445

Closed mdickson closed 6 years ago

mdickson commented 6 years ago

Set an enum that makes .NET 4.5 prefer TLS 1.2

appurist commented 6 years ago

Isn't it true that this is not telling .NET to prefer TLS 1.2, but rather to support only TLS 1.2?

Wouldn't it be much safer to use: ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12; so that TLS 1.2 is added to the supported list. The way I understand it is that .NET will automatically prefer the highest/best protocol if available, so that would work just as we want it. I'm a bit concerned that some websites that used to be supported from Halcyon servers would no longer be supported. (I know it's crytographically insecure but it could be a change that breaks existing content, and we continue to support HTTP anyway.)

It also seems that the default for SecurityProtocol in 4.6.x isn't just Tls12, it's Tls | Tls11 | Tls12, so adding it to the existing values should make it work as if we upgraded to 4.6.x.

Also, as we move forward in the future, setting it explicitly to Tls12 would limit the code from using better method, which might become important if TLS 1.2 also eventually becomes insecure.

appurist commented 6 years ago

Excellent, merging...