IslandzVW / halcyon

InWorldz Halcyon 3d virtual reality world simulator
BSD 3-Clause "New" or "Revised" License
21 stars 26 forks source link

Fix issue #418: Invoke the code to check and apply a fee on group creation if configured. #461

Closed appurist closed 6 years ago

appurist commented 6 years ago

The code to check and apply a fee on group create has never been invoked. This commit updates the group creation (when using FlexiGroups) to check and apply if configured with PriceGroupCreate in the Halcyon.ini file.

appurist commented 6 years ago

I'm going to add an error response to the user in the event of a group creation failures. I'm also going to take a look at skipping all of this code (first comment) if the operation is free.

appurist commented 6 years ago

Unfortunately it's not possible to precheck if a fee applies to group creation because it is the money module that owns that data (that's why we're trying to get a reference to the money module here in the first place, to do that check). However, I've added the user message for the failure case (and fixed the spelling error in the success case!).

appurist commented 6 years ago

I'm going to fix that mesh upload null references as part of this PR since it's basically the same code. One more commit coming.

appurist commented 6 years ago

Okay, I think that's it. Good to go?