search

IsmaelMartinez / teams-for-linux

Unofficial Microsoft Teams for Linux client
GNU General Public License v3.0
2.82k stars 233 forks source link

Meeting notifications not working with "new teams" #1234

Open cim-- opened 5 months ago

cim-- commented 5 months ago

Describe the bug Notifications sent to notification-daemon no longer happen with the "new teams". This does work - if somewhat erratically - with the "classic teams". I have tried both "web" and "electron" notification methods with the same results. UseMutationTitleLogic does work for systray icon changes for "permanent" notifications, it's just the transient ones which are missing.

To Reproduce 1) Start Teams 2) Have someone else start a meeting you are present at / send a chat message 3) Nothing happens 4) Use notify-send to test notification daemon 5) Receive notification as normal (There is presumably more to it than this as other people have mentioned in other issues that it works for them, but I can't tell what, unfortunately)

Expected behavior Notifications of new meetings, chat messages, etc. sent to notification daemon as with classic teams

Desktop (please complete the following information):

Debug The main obvious error seems to be

Failed to start Activity Hub by assigning Event Handlers error @ v2/:3 (anonymous) @ /opt/teams-for-linux/resources/app.asar/app/browser/tools/activityHub.js:44

Full log: teams.log

(Sorry, this doesn't feel like a lot of help - happy to answer more detailed questions about my system config and try other config settings, etc.)

IsmaelMartinez commented 5 months ago

Can you try with 1.4.30 or higher? I suspect you are using the newer version of MS teams (v2).

cim-- commented 5 months ago

Yes, this is teams v2 (it did work at least most of the time with teams v1) Tried again with 1.4.31 and the same problem (and same Activity Hub error in the log file) I'll give 1.4.33 a go once the debian package is available. Thanks

IsmaelMartinez commented 5 months ago

https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.34 is available and it should work again. Can you try it? Thanks

Azeirah commented 5 months ago

I was experiencing the same issue after switching from the older teams to the newer teams, I just installed v1.4.34, I'll let you know if it resolves the issue.

cim-- commented 5 months ago

Still no in 1.4.34, unfortunately - or at least, mostly not: occasionally a notification does come through, which is strange. Maybe you can see some pattern in this that I'm missing? NotificationMethod is currently set to "electron" - happy to retry with "web" instead if you think that would be useful.

For the chat messages - though of course not the meeting notifications where this wouldn't apply - the systray icon did correctly update the unread count every time.

IsmaelMartinez commented 5 months ago

Can you try https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.4.35 ? Playing catch-up with MS with the idleTimeout that "might" have been putting you into idle (so you don't get notifications.

cim-- commented 5 months ago

Sorry, no, that also hasn't worked. Thanks for trying.

(Idle is of course the time I most want to get notifications - not sure what MS were thinking there)

jijojosephk commented 5 months ago

I'm on GNOME I get notifications. Earlier with angular we need to implement something ourselves to show the notification. But with react version, it's shown similar to regular chat notifications.

cim-- commented 4 months ago

Just as another data point, I've gone back to "classic"/"v1" teams for now, and that is sending chat and meeting start notifications through to notification-daemon absolutely fine (including sending notifications for meetings which have already started when I open the client), so most of the process seems solid, just something about the new/v2 teams not generating them properly. (I'll probably be sticking around on "classic" for as long as I can, but please let me know if there's anything else I can test)

mikedld commented 4 months ago

Same here. I do notice the notifications from time to time, but they're seemingly displayed within the window (i.e. as part of the webpage, in lower right corner), not as desktop notifications (as a separate floating window, in my setup in upper left corner), so I only see them when I switch to the Teams window which is not at all how it's meant to work :) Sticking to v1 too for the time being (which the yellow bar never stops telling me will stop working in a month or so).

cim-- commented 3 months ago

I get the same as mikedld - are some people finding that on their desktop environment the little blue notifications can escape from the Teams window and be shown elsewhere on the desktop/in other workspaces? If so that's not how it works on mine, unfortunately.

IsmaelMartinez commented 3 months ago

Hi @mikedld and @cim-- , did you try with the 'electron' notification option? It is called notificationMethod in the config options https://github.com/IsmaelMartinez/teams-for-linux/tree/develop/app/config I suspect the web option (default) is just showing in within the browser, while electron will trigger outside the browser, but electron is a bit silly understanding if it should show the notifications as in this comment. https://github.com/IsmaelMartinez/teams-for-linux/issues/1234#issuecomment-2090102185

cim-- commented 3 months ago

Hello - yes, I've been using notificationMethod: electron. Since that comment it has generally become more consistent and not sent any notifications through to notification-daemon, though. Thanks

IsmaelMartinez commented 3 months ago

I assume we can close this issue then as using electron you get notifications. Do report back if needs re-open (Maybe I misunderstood)

cim-- commented 3 months ago

Hello - no, please keep open. Using electron (mostly) doesn't help, it's still an issue with Teamsv2.

I get the in-app-window notifications correctly (but not very usefully)

I only get the notifications via notification-daemon in Teamsv2 extremely rarely (possibly only when the app window is actually closed, but not all of those either) - whereas they also worked consistently in Teamsv1.

Thanks

IsmaelMartinez commented 3 months ago

Fyi, using the official MacOS app, I don't get notifications since moved to teams-v2. So this might just be a MS problem after all.

Some of my colleagues did manage to get their notifications back, again, in the official MacOS app, by going to settings, notifications and disabling and re-enabling them.

Also notice that the electron notifications implementation has always been sub optimal, as it can't detect things like the app being in another workspace or minimised. I think it only notifies if the app is out of focus, but I don't fully remember.

But we will keep trying to find a way