search

IsmaelMartinez / teams-for-linux

Unofficial Microsoft Teams for Linux client
GNU General Public License v3.0
2.66k stars 221 forks source link

Screen share doesn't work since last update (1.7.3) #1313

Closed andjelatomic closed 1 month ago

andjelatomic commented 1 month ago

Describe the bug I am not able to do screen share anymore during the video call. I am using Linux Mint Cinnamon (with X11 and Xorg), as it was for all previous versions.

To Reproduce Steps to reproduce the behavior:

  1. Join the video call
  2. Click on Screen share
  3. Nothing is happening on click (no list of screens / applications )

Expected behavior It is supposed to have list of screens/applicaitons where you can select one to share

Desktop (please complete the following information):

Debug

[32623:0624/090904.070133:ERROR:CONSOLE(1)] "Request Autofill.enable failed. {"code":-32601,"message":"'Autofill.enable' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1) [DEBUG] Badge count set to '1' [DEBUG] GetSystemIdleState => IdleTimeout: 300s, IdleTimeoutPollInterval: 10s, ActiveCheckPollInterval: 2s, IdleTime: 0s, IdleState: 'active' [DEBUG] Badge count set to '1' [DEBUG] GetSystemIdleState => IdleTimeout: 300s, IdleTimeoutPollInterval: 10s, ActiveCheckPollInterval: 2s, IdleTime: 0s, IdleState: 'active' [DEBUG] Badge count set to '1' [32623:0624/090917.474849:ERROR:CONSOLE(1)] "Request Target.setAutoAttach failed. {"code":-32601,"message":"'Target.setAutoAttach' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1) [32623:0624/090917.692479:ERROR:CONSOLE(1)] "Request Target.setAutoAttach failed. {"code":-32601,"message":"'Target.setAutoAttach' wasn't found"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1) [DEBUG] GetSystemIdleState => IdleTimeout: 300s, IdleTimeoutPollInterval: 10s, ActiveCheckPollInterval: 2s, IdleTime: 0s, IdleState: 'active' [DEBUG] GetSystemIdleState => IdleTimeout: 300s, IdleTimeoutPollInterval: 10s, ActiveCheckPollInterval: 2s, IdleTime: 0s, IdleState: 'active'

teams-for-linux --webDebug --appLogLevels=error,info,warn,debug
limes007 commented 1 month ago

Same problem here. Is there a workaround? Will a rollback to 1.7.2 help?

Update: I did a rollback to last version available on Flathub, which seems v1.5.0. Sharing is now working again with this version.

KlausMehling commented 1 month ago

Same on Ubuntu 5.14.0-1051-oem

Dardrai commented 1 month ago

I tried 1.7.2 and then I fixed the build for 1.7.0 and 1.7.1 locally to create the arch package -> none of them worked here. I had to revert to 1.6.1 to be able to screen share again. (I use X11, and used the Flatpak version prior and now the aur package https://aur.archlinux.org/packages/teams-for-linux for testing the versions)

antonioabajo commented 1 month ago

It's not possible select the Screen you want to share. In record video clips, selecting screen sharing to record, the same problem happems.

When I click in select your screen to record this alert is shown and the window selector is not shown.

image

sprudel79 commented 1 month ago

Same issue for me with Linux Mint 21.3, also the app is crashing sometimes in the background. This didn't happen with previous release so there must be a recent change triggering this.

TomSp commented 1 month ago

teams needs staring from now on popups for selecting sharing image

TomSp commented 1 month ago

howto allow it in sandbox ?

pavellisy commented 1 month ago

on Fedora 40 (Xorg + Nvidia driver ... nvidia/535.179, 6.9.5-200.fc40.x86_64, x86_64) cannot share screen with latest version: 

          ID: com.github.IsmaelMartinez.teams_for_linux
         Ref: app/com.github.IsmaelMartinez.teams_for_linux/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 1.7.3
     License: GPL-3.0
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 272,5 MB
     Runtime: org.freedesktop.Platform/x86_64/23.08
         Sdk: org.freedesktop.Sdk/x86_64/23.08

      Commit: 297c3e6982dabe96d9d9a93b51c4cc8c01210b589c6da82a9cb74590530c4ad3
      Parent: 186db042383e237fff9e6136a59a7f389a9fba247ce85f4748b9f25f50c7b45d
     Subject: Update teams-for-linux module (58d41a92)
        Date: 2024-06-22 07:39:03 +0000

but in Fedora 40 (the same updates) with Wayland sharing is possible

on Fedora 40 (Xorg + Nvidia driver ... nvidia/535.179, 6.9.5-200.fc40.x86_64, x86_64) this build (latest previous) share screen correctly:

          ID: com.github.IsmaelMartinez.teams_for_linux
         Ref: app/com.github.IsmaelMartinez.teams_for_linux/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 1.5.0
     License: GPL-3.0
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 268,5 MB
     Runtime: org.freedesktop.Platform/x86_64/23.08
         Sdk: org.freedesktop.Sdk/x86_64/23.08

      Commit: 186db042383e237fff9e6136a59a7f389a9fba247ce85f4748b9f25f50c7b45d
      Parent: 72e9ecddb53885ece3332f192918b12793d1ad59646da813da86734b741578f3
     Subject: Update 2 modules (6dbef8d0)
        Date: 2024-06-21 23:05:07 +0000
z1atk0 commented 1 month ago

+1 ... same here, Slackware64-15.0, X11 & GNOME 46. :unamused: Reverting back to 1.6.1 allows sharing again.

Usaamah99 commented 1 month ago

+1 ... Same Here. Arch Linux. Using teams-for-linux 1.7.3 from the AUR

bundi78 commented 1 month ago

Also, with 1.6.1, screen share is working, with 1.7.[1..3] not

mcichocki commented 1 month ago

I don't know if anyone else is having trouble receiving incoming calls because the message 'calling...' appears, and after answering, nothing happens. The latest release is a disaster; did anyone even test it beforehand?

banholzer commented 1 month ago

@mcichocki

I don't know if anyone else is having trouble receiving incoming calls because the message 'calling...' appears, and after answering, nothing happens. The latest release is a disaster; did anyone even test it beforehand?

this is another issue I guess. Please separate one issue from another. I realized this sharing problem already on the pre-release but was not able to file an issue/look into the details --> this is Open Source. Everybody is encouraged to support and test pre-releases. I had no issues so far with accepting calls.

jbauerrfid commented 1 month ago

Can confirm screen share is broken in 1.7.3

The new Teams version came from snap today. Since then, no screen or window can be selected for sharing.

Client is Ubuntu 22.04 with x11 (since screen share isn't working on wayland as well, but that is another issue).

claudemirtech commented 1 month ago

I have the same problem I clicked on share but noting anithing happning. I back to 1.6.1 version

adriandelgg commented 1 month ago

Same here with Teams v1.7.3 on Debian 12 X11 i3wm. Reverting to 1.6.1 worked. Please fix ASAP

gwozniak commented 1 month ago

The same issue on Debian 12 X11 KDE and Debian testing X11 KDE, reverting to 1.6.1 resolves issue.

arbexmb commented 1 month ago

Same here. I am using Ubuntu 22.04.4 LTS. Not only that, I can't open my camera in calls aswell.

casta commented 1 month ago

By the way, screen sharing is only broken under x11. It’s working perfectly fine when under wayland.

gwozniak commented 1 month ago

By the way, screen sharing is only broken under x11. It’s working perfectly fine when under wayland.

Yes and no on my side, I re-logged with kwin wayland on trixie and I saw separate window allowing to choose desktop/window to share, but after clicking share I saw that (both v.1.6.1 and v.1.7.3): image

I'm glued to pulse on this PC due to problems with usb camera's mic under pipewire, I will recheck it tomorrow on my work PC with bookworm where I'm using pipewire.

IsmaelMartinez commented 1 month ago

Thanks for reporting. I will put back 1.7.3 as pre-release and go back to 1.6.1 as the latest. I did thought it has been tested as a pre-release enough, but obviously it wasn't.

I suspect the issue is around the refactoring on this area

image

Around this file https://github.com/IsmaelMartinez/teams-for-linux/pull/1291/files#diff-33922750afb4f00fe72934ba21d348e07c9eda191fddcdf19954f3b1efa36b8d but I don't know when I will have time to have a look at it.

If you got a problem with 1.6.1, that would be another issue. Apologies for the issue! Refactoring sometimes do create problems.

camspiers commented 1 month ago

I think I see what the issue is.

https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/mainAppWindow/browserWindowManager.js#L72

We are no longer calling assignSelectSourceHandler.

So line 72 should be:

ipcMain.on('select-source', this.assignSelectSourceHandler());

EDIT: I have opened https://github.com/IsmaelMartinez/teams-for-linux/pull/1315 with a fix.

dzaghal commented 1 month ago

Sorry if not related, but this morning my v1.7.something got "updated" to 1.6.1 by snap. It was intentional to solve this problem?

BTW, yesterday screen share was working nicely (I have to login Ubuntu in Xorg instead of Wayland to make it work)

gwozniak commented 1 month ago

So line 72 should be:

ipcMain.on('select-source', this.assignSelectSourceHandler());

Confirming fix works on Debian 12 X11 KDE :)

IsmaelMartinez commented 1 month ago

Sorry if not related, but this morning my v1.7.something got "updated" to 1.6.1 by snap. It was intentional to solve this problem?

BTW, yesterday screen share was working nicely (I have to login Ubuntu in Xorg instead of Wayland to make it work)

Aye, I did revert the snap latest to 1.6.1 as 1.7.3 was broken. Once 1.7.4 is out, I will probably leave it a couple of days until I mark it as stable.

I think I see what the issue is.

https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/mainAppWindow/browserWindowManager.js#L72

We are no longer calling assignSelectSourceHandler.

So line 72 should be:

ipcMain.on('select-source', this.assignSelectSourceHandler());

EDIT: I have opened #1315 with a fix.

Thanks for the fix! I left a couple of small changes needed. Basically increase release number etc. Thanks again!

IsmaelMartinez commented 1 month ago

This should be fixed in https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.7.4

jbauerrfid commented 1 month ago

Really appreciate this, the inofficial teams-for-linux is still light years better than the horrible Teams PWA from Microsoft. Kudos that IsmaelMartinez got it fixed so quick.

IsmaelMartinez commented 1 month ago

@camspiers is who deserves the credit! (and the community of contributors that keeps this alive).

He did found the problem and put a PR for it. A true legend ;)

adriandelgg commented 1 month ago

Thank you both @camspiers & @IsmaelMartinez!

thekk1 commented 1 month ago

@camspiers & @IsmaelMartinez Thanks for your good work guys! I really appreciate it. Is it possible to release a new flatpak, too?

IsmaelMartinez commented 1 month ago

Flatpack should be already out. But they can take a few/many hours. Their way of releasing stuff to people is "unique"

thekk1 commented 1 month ago

Flatpack should be already out. But they can take a few/many hours. Their way of releasing stuff to people is "unique"

Understood. Thx for your time and the information.

IsmaelMartinez commented 1 month ago

confirmed it was released yesterday. It should probably be out tomorrow https://github.com/flathub/com.github.IsmaelMartinez.teams_for_linux/pull/117