search

IsmaelMartinez / teams-for-linux

Unofficial Microsoft Teams for Linux client
GNU General Public License v3.0
2.73k stars 228 forks source link

Provide Flatpak packaging #41

Closed kolya-ay closed 5 years ago

kolya-ay commented 5 years ago

I would be cool to have flatpak build along with snap and publish it to flathub to distribute app updates.

IsmaelMartinez commented 5 years ago

feel free to add it. I don't really have the time at the moment to implement this but I am happy to support you.

IsmaelMartinez commented 5 years ago

Seems to be a open issue in the backlog to support that.

https://github.com/electron-userland/electron-builder/issues/512

We are using electron-builder to build the different packaged versions.

Hopefully they tackle it in there soon or, if you want to add it, just probably concentrate your efforts on adding it in the electron-builder.

I will keep it open so I check the electron-builder every now and then. Thanks for the suggestion again!

gabops commented 5 years ago

Hello there!

I've created a Flatpak distribution of this amazing Teams client for Linux. You can install it from the Flathub repo at https://flathub.org/apps/details/com.github.IsmaelMartinez.teams_for_linux or get the code of the flatpak itself, report issues, PRs etc at https://flathub.org/apps/details/com.github.IsmaelMartinez.teams_for_linux

Thank you for this useful tool.

IsmaelMartinez commented 5 years ago

Hi @gabops ,

Amazing! Thanks a lot for it. I just got a few questions for future maintenance, etc.

How do you know when to release a new version? Are you building from master? Do you want me to ping you after every release of is there some magic build in the flathub integration?

Thanks again!

gabops commented 5 years ago

Hi @IsmaelMartinez,

Your are very welcome! About your questions:

How do you know when to release a new version?

currently I have a "watch" configured for new releases in your repo. Everytime you release a new version I will get a notification.

Are you building from master?

No, I am pointing to the release by doing this in the flatpak manifest:

      - type: git
        url: https://github.com/IsmaelMartinez/teams-for-linux.git
        tag: v0.3.0

So, the flow could be:

  1. I get a notification of a new version from your repo.
  2. I create a new branch for testing in the flatpak teams repo (https://github.com/flathub/com.github.IsmaelMartinez.teams_for_linux)
  3. I will update the manifest and other changes if required. Then I will push and PR from that branch against master.
  4. If everything is ok it will be merged and all the users will get the update on their systems.

Or could be as well:

  1. Any user realizes there is a new release in your repo.
  2. Creates a fork of the Flathub teams repo.
  3. Makes a PR from the fork against the master branch in the Flathub teams repo.
  4. If everything is ok, flathub developers or me approve or not the merge.
IsmaelMartinez commented 5 years ago

Great! Maybe worth adding a "get it in flathub" badge in the main readme... But we need to do that for snap and arch also so not needed to worry at this moment. Thanks again!! I will close this as is now done!

bubble75 commented 5 years ago

Procedure described for new releases doesn't seem to work. flatpak is still on 0.4.0

IsmaelMartinez commented 5 years ago

I believe there is an open PR for it (not fully finished). I don't maintain flatpack not aur. Once azure pipelines are in place I might look into automating the flatpack, but I am pretty busy at the moment. Feel free to help on the flatpack. I believe is just a command that needs run to update a file. Let me know if you have any questions.

On Thu, 5 Sep 2019, 08:32 bubble75, notifications@github.com wrote:

Procedure described for new releases doesn't seem to work. flatpak is still on 0.4.0

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/IsmaelMartinez/teams-for-linux/issues/41?email_source=notifications&email_token=AADJHEFAY4FB3ADK6HVJS6LQICYX3A5CNFSM4GQUS2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD56EOEI#issuecomment-528238353, or mute the thread https://github.com/notifications/unsubscribe-auth/AADJHEBTCMPTIH6RSLXQBOLQICYX3ANCNFSM4GQUS2XA .

IsmaelMartinez commented 5 years ago

the issue that I am referring is this one: https://github.com/flathub/com.github.IsmaelMartinez.teams_for_linux/issues/6

On Thu, Sep 5, 2019 at 8:53 AM Ismael Martinez Ramos < ismaelmartinez@gmail.com> wrote:

I believe there is an open PR for it (not fully finished). I don't maintain flatpack not aur. Once azure pipelines are in place I might look into automating the flatpack, but I am pretty busy at the moment. Feel free to help on the flatpack. I believe is just a command that needs run to update a file. Let me know if you have any questions.

On Thu, 5 Sep 2019, 08:32 bubble75, notifications@github.com wrote:

Procedure described for new releases doesn't seem to work. flatpak is still on 0.4.0

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/IsmaelMartinez/teams-for-linux/issues/41?email_source=notifications&email_token=AADJHEFAY4FB3ADK6HVJS6LQICYX3A5CNFSM4GQUS2XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD56EOEI#issuecomment-528238353, or mute the thread https://github.com/notifications/unsubscribe-auth/AADJHEBTCMPTIH6RSLXQBOLQICYX3ANCNFSM4GQUS2XA .

bubble75 commented 5 years ago

I actually meant human factor. I found nice released rpm and it is enough for me, thanks!