Low quality in screen sharing on 1 to 1 calls

julian-alarcon commented 5 years ago

When using screen sharing between only 2 peers the quality of the screen is pretty low.

If the screen sharing is between 3 or more people the quality is great with no issues. If you are in a one and one screen sharing and invite to someone else the quality wont be improved, you have to cancel and reshare the screen to fix the quality issue.

I'm using Snap build on Ubuntu 18.04 with Xorg (no Wayland) using version 0.1.16 of teams-for-linux.

Attached is an screenshot that show the issue.

IsmaelMartinez commented 5 years ago

ok, version 0.3.2 should be out in snap edge soon (next hour) with this background stuff. please comment with whatever you find. If I don't see any comments in the next few days I will close this ticket (as mentioned before) as it feels like it has become a bit of a dumping ground.

update: travis seems to be a bit f*&( so maybe is out there tomorrow...

byteSamurai commented 5 years ago

I don't understand how this might be related to this issue. Could you explain it please?

Furthermore I managed to get some time to investigate on this issue after 12th July. I have also a technical user/account in a separate network to deep a bit deeper. Is it possible to keep this ticket open while July? I will report back anyway what I have done.

IsmaelMartinez commented 5 years ago

hi @byteSamurai , happy to keep it open if still is an issue.

The reasoning behind is that antialiasing is a rendering technique, and some people seems to be having an issue with the rendering. .

Also, is something new in the docs (added 2 days ago). The issue seems to be old but still present in electron (as far as I can see from the docs).

As that change should not have any side effect, I thought worth a try.

To be honest, I have tried doing screenshare with quite a few different monitors in many different circumstances but video was always fairly decent.

Happy to keep it open, in any case, seems like travis-ci is not doing behaving so 0.3.2 will take longer to be out.

Thanks for checking it out, if you want, it might worth investigating moving to electron 5, but the window.chrome.runtime override in https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/browser/desktopShare/chromeApi.js seems to not work anymore in electron 5.x (not 6 or 7) - Mentioning it as I think you did work on that area.

rumatoest commented 5 years ago

In 0.3.2 Screen sharing works way better. Resolution is Ok

IsmaelMartinez commented 5 years ago

@julian-alarcon , as you did open it, can you have a check to see if 0.3.2 screen sharing now works fine? Ta

IsmaelMartinez commented 5 years ago

also @byteSamurai, can you also check if 0.3.3 (or 0.3.2) quality has improved? it does sound crazy that setting the background white fixes this issue but I have seen worse/crazier fixes.

byteSamurai commented 5 years ago

Yes, but keep in mind I need to start next weekend. (time is like sand)

IsmaelMartinez commented 5 years ago

I have added that background stuff to version 0.3.2. If that works, then feel free to play around with version 5 of electron. Is giving me a few headaches (and I have no much sand, I mean time).

In any case, thanks a lot for expending time on this!

julian-alarcon commented 5 years ago

I can confirm, using the latest version (edge in Snap Store) 0.3.3 the quality improved a lot! There are not differences! I think that we can close it.

This may also be related with the changes that MS made to the videocall interface recently (square icons and maybe under the ground changes).

IsmaelMartinez commented 5 years ago

closing and starting to pack stuff to release 0.4.0... once we move to electron 5 (if ever) I change the number to 1.0.0. Thanks!

byteSamurai commented 5 years ago

We did some test here with several users, comparing mostly v0.2.0 with the current master branch. Outcome -> Quality is identical, but not bad at all!

In my opinion MS may did some optimizations under the hood at the same time we were try to discover what is going on here.

As everyone seems to be happy, case closed and again GJ @IsmaelMartinez. Thank you!

As far as I see, there is some polish needed on the dialog selecting the app/window one likes to share. Also the current sharing stream window could be a chromeless windows. I don't know how this is related to electron 5. What can I do right now?

(@IsmaelMartinez you got mail from me, feel free to say me, how I might help you )

IsmaelMartinez commented 5 years ago

Hi @byteSamurai ,

Thanks for checking it. To be honest, I never experienced the issue myself so just tried to fix something blind (what is fairly tricky)

Replying your email in here, any help is always more than welcome.

I just created the Gitter channel so hopefully communication is a bit better than now. It might also help people to help each other.

My current plan is to merge the PR that is in the middle, and release 0.4.0. Then spend sometime with the electron 5. I don't think is urgent yet, but there are only two parts not working.

We will need to move to electron 5/6/7 soon.

If you want a challenge, that task is then the one for you ;) If you prefer something easier, but equally useful, working in the screensharing area might also be a great idea. Now it works but got a few edges that will be nice to trim :) There might be a couple of challenges around it.

Thanks again!

julian-alarcon commented 5 years ago

This issue appeared again with version 0.6.3. One to One quality is bad, but in groups there is no issue.

It's possible to try the same workaround previously used?

julian-alarcon commented 5 years ago

The workaround is in place... Maybe is a new bug.

IsmaelMartinez commented 5 years ago

Hi, can you confirm it is not on 0.6.0 (stable) also with the 0.6.4 (as it wait now to clean the cache)? Just to see if is related to our app or something from the website part.

If is the clearCache stuff I will then put it as a config option.

Thanks

On Fri, 9 Aug 2019, 17:01 Julian Alarcon, notifications@github.com wrote:

The workaround is in place... Maybe is a new bug.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IsmaelMartinez/teams-for-linux/issues/61?email_source=notifications&email_token=AADJHEHKS6DO5HFS2EU2I2DQDWIHHA5CNFSM4G6T6QIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37CXZA#issuecomment-519973860, or mute the thread https://github.com/notifications/unsubscribe-auth/AADJHECHBEU6XHNWL7IY6E3QDWIHHANCNFSM4G6T6QIA .

IsmaelMartinez commented 5 years ago

Actually, we are reverting the changes from 0.6.3 so, hopefully, this goes away as they go away. Can you test with 0.6.0 and see if the quality is fine? Once the other stuff is packet and ready to go I release a edge version of 0.6.5 and see if still the case.

Hopefully I get some time at lunch time on Monday!

byteSamurai commented 5 years ago

JBTW: I am still on 0.4.0 and we are facing the again the same issue. Could it be something on MS side? :thinking:

IsmaelMartinez commented 5 years ago

@byteSamurai , do you have the blank/white loading screen every now and then? Just to check if you need to buildup cache in order for the call to be better... to be honest, I doubt it.

Are group calls still ok? Is this only 1-2-1? And yeah... probably Microsoft and/or your network.

IsmaelMartinez commented 5 years ago

worth having a look at this (but grab a coffee or two before you start, pretty long read): https://docs.microsoft.com/en-us/microsoftteams/monitor-call-quality-qos

IsmaelMartinez commented 5 years ago

Hi @byteSamurai and @julian-alarcon , did you get a chance to read that long document? also... are you still experiencing the issue? Thanks!

byteSamurai commented 5 years ago

@IsmaelMartinez Actually QoS should be established in our networks. But I will ask our IT department as they are monitoring most of our traffic, maybe also QoS.

Nevertheless: I don't think its related to this because some of my colleagues are willing to work with me via Zoom. In Zoom gives me a perfect quality every time! No matter if I work from home or not.

At the moment I have a completely different problem: After almost every start if teams it stucks in initializing. If I clear the cache, I can log in once (after a use-the-desktop-app notification).

Affects 0.4.0 as well as 0.6.0 so it looks it is related totally on something MS has changed?

I am investigating and write an issue if I am sure, its not related to our AD.

IsmaelMartinez commented 5 years ago

That is #171. Look at my last comment. 0.6.6 or higher should have this fixed

On Wed, 14 Aug 2019, 21:34 Alfred Feldmeyer, notifications@github.com wrote:

@IsmaelMartinez https://github.com/IsmaelMartinez Actually QoS should be established in our networks. But I will ask our IT department as they are monitoring most of our traffic, maybe also QoS.

Nevertheless: I don't think its related to this because some of my colleagues are willing to work with me via Zoom. In Zoom gives me a perfect quality every time! No matter if I work from home or not.

At the moment I have a completely different problem: After almost every start if teams it stucks in initializing. If I clear the cache, I can log in once (after a use-the-desktop-app notification). [image: image] https://user-images.githubusercontent.com/6654064/63054081-774e8900-bee3-11e9-9ec5-14aef824df9b.png

Affects 0.4.0 as well as 0.6.0 so it looks it is related totally on something MS has changed?

I am investigating and write an issue if I am sure, its not related to our AD.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IsmaelMartinez/teams-for-linux/issues/61?email_source=notifications&email_token=AADJHEHPVC3HV5Z7WR6CGULQERT5XA5CNFSM4G6T6QIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KA4CY#issuecomment-521408011, or mute the thread https://github.com/notifications/unsubscribe-auth/AADJHEBT2N7MYXLO6WRQEJTQERT5XANCNFSM4G6T6QIA .

mschirmacher commented 5 years ago

@IsmaelMartinez bad news: from yersterday to today Screensharings i reveice are completly blurred. Was running 0.6.6 and installed 0.6.7 today - no difference. I guess microsoft again made some changes :-(

IsmaelMartinez commented 5 years ago

one-2-one calls or group ones? We don't do screensharing at my office (as we all sit pretty close to each other) so it is always a bit more difficult to test this things... Is it possible to test with version 0.5.0 and see if is better? (just to make sure is not the newer version of electron that introduce this)

mschirmacher commented 5 years ago

Ok we tested a bit: It's blurred in group vide chats as well as in scheduled meetings in 0.5.0, 0.6.6 and 0.6.7 BUT it's crystal clear in one-2-one calls - so maybe i'll just open a new issue for that one?

IsmaelMartinez commented 5 years ago

Open a new issue but I will point you 1st to MS... https://docs.microsoft.com/en-us/microsoftteams/monitor-call-quality-qos

IsmaelMartinez commented 5 years ago

I will actually close this one and move it to the #241 as this issue is a bit polluted.

As I mentioned in the other issue, I think it might be one of the changes introduced in 0.5.0.

IsmaelMartinez commented 5 years ago

Ignore my previous message. Reopening

IsmaelMartinez commented 5 years ago

Can you guys test if it now works? according to https://github.com/IsmaelMartinez/teams-for-linux/issues/241#issuecomment-523813914 MS has fixed something... and is in the same area so maybe it also fixes our problems?

julian-alarcon commented 5 years ago

Hi!

I just made a test with snap version edge: 0.7.0 2019-08-23 (59) 52MB

No issues! Seems to be a server/service issue from Microsoft, and now the fixed again.

IsmaelMartinez / teams-for-linux

Low quality in screen sharing on 1 to 1 calls #61

Nevertheless: I don't think its related to this because some of my colleagues are willing to work with me via Zoom. In Zoom gives me a perfect quality every time! No matter if I work from home or not.