Code review request

[GoogleCodeExporter]

agendaplugin/usercalendarviewer.cpp: 521

        d->aTomorrow->setText(tkTr(Trans::Constants::TOMORROW));
        d->aTomorrow->setToolTip(d->aTomorrow->text());
        d->aNextWeek->setText(tr("Beginning of next week"));
        d->aNextWeek->setToolTip(d->aNextWeek->text());
        d->aNextMonth->setText(tr("Beginning of next month"));
        d->aNextMonth->setToolTip(d->aNextMonth->text());

I changed the "next week" to "beginning of next week", same with month, because 
the calculation (with an additional corrected error) was pointing to that dates.

I discussed this with my girlfriend (which is also a doc) and we came to the 
conclusion that most of the times a doctor (or his helper) does not need to 
give the next appointment to the *beginning* of the next week/month. It is of 
no importance what the beginning of the next week/month is;
Most of the times it depends on the disease, and the doc wahts to see the 
patient IN ONE WEEK or IN ONE MONTH.

So if you don't mind, I'll change that calculation from "beginning of next 
week/month" to "in one week/month" - that does make much more sense IMHO.
Thoughts?

Original issue reported on code.google.com by christian.a.reiter@gmail.com on 3 Oct 2012 at 10:18

[GoogleCodeExporter]

Ok that's interesting. Can't we keep both approches?
- beginning next week/month
- and in one month/week/quarter

Original comment by eric.mae...@gmail.com on 3 Oct 2012 at 10:24

[GoogleCodeExporter]

Seems that my last mail is somehow gone in the data nirvana... ;-) So again:

Hm, I think that adding features over features is a bad idea. We should not
make the "KDE-error": each idea gets immediately implemented as new menu
item. ;-)
Eric, you work on OSX, so you know what I mean: We should think what 95% of
all doctors need, and implement that, perfectly. and kill the rest, or make
it available for configuration, if necessary.
But I don't think that "beginning of next week" AND "in one week", same for
month, quarter, and surely today/tomorrow are much of a help to any doctor
(or his helpers) - it's just distraction.

Normally, when you see a patient, you want to keep an eye on the disease,
so prefereable you se him tomorrow if it's really bad, in 2-3 days if it's
so-so-la-la, and most of the time you will see him in a week, more or less.
It does not make sense to point to the beginning (e.g. Monday) of the next
week per default because the you will have a over-average nnumber of
patients on monday per default and will have to select the date (to
tuesday/wednesday) anyway. So IMHO MUCH better is "in one week", that will
suffice for >90%.
IF you want to REALLY see the patient on the next monday (maybe today is
thursday/friday), you can ANYTIME open the next week in the calendar and
have the leftmost day as your wanted day.
But for "in one week" you don't have a normal pattern, so this one (same
with "in one month") is needed IMHO.

Whattooyasay? ;-)

Original comment by christian.a.reiter@gmail.com on 3 Oct 2012 at 10:36

[GoogleCodeExporter]

update this the smartest way... :D

Original comment by eric.mae...@gmail.com on 12 Oct 2012 at 1:14

[GoogleCodeExporter]

?

Original comment by christian.a.reiter@gmail.com on 12 Oct 2012 at 1:30