IsoFrieze / DiztinGUIsh

A Super NES ROM Disassembler

GNU General Public License v3.0

270 stars 26 forks source link

Fix cartridge title name encoding (needs to be ShiftJIS string encoding) #49

Closed binary1230 closed 3 years ago

binary1230 commented 3 years ago

WIP, needs a little more testing before it's ready.

fix shift-JIS encoding for reading cart titles

binary1230 commented 3 years ago

All the stuff related to the cart title SHOULD be working now.

However, couple things left:

[x] Make the verification error that pops up be a skippable warning 'if you know what you're doing click here'
[x] Write unit tests for checksum bytes for both Hi and Lo roms. I think we've been wrongly assuming a HiRom offset for all ROMs, when we should be picking different offsets for different rom types.
[x] Test 2 byte characters for ROM cartridge names, make sure they still equal 21 BYTES (not 21 CHARS)

binary1230 commented 3 years ago

this is pretty thoroughly tested (and somewhat overkill on the testing hah)

This PR ended up being heavy on refactoring out a few subsystems to make future fixes easy, and allow load/save/import functionality to be unit tested. it should make things much simpler in the future to deal with.

I spun off a few low-pri issues that I didn't want to hold up getting a release out for, they are:

51 #52 #53

Thanks @LuigiBlood for the input and Sneslab discord for info on a few things in here.