Open binary1230 opened 3 years ago
Friend of mine wrote a working script for this problem: https://github.com/Dom-aka-Doke/Advanced-SNES-ROM-Utility/blob/master/Advanced_SNES_ROM_Utility/Form3.cs Starting at line 470. Important to note that all 21 bytes are used or has to be filled with 0x20
This is a continuation of #50 (more info there), if the Cartridge Rom header field in the SNES ROM header contains characters that are not one-byte per-character (like some Japanese glyphs are), then we might not always be doing the right thing when encoding/decoding.
We should write a unit test that shows a situation where:
And then given those conditions, check all the other areas of the code to make sure it behaves nicely there. Particularly, paying attention to anything that uses
RomUtil.LengthOfTitleName
I was confident enough for the couple ROM headers I tested that I think we have this decently implemented (and definitely for English). and, there is extensive unit testing support for this now. but it would be good to test this final bit of the edge case.