search

IsolatedLun / PzCompare-Build

MIT License
1 stars 1 forks source link

Items display their id, rather than their user-readable name #3

Closed cosmo-naut closed 2 years ago

cosmo-naut commented 2 years ago

Should be "Hattori Hanzo Katana" or whatever instead of 'KillBill', this will allow non-dev users to use the applet easily

cosmo-naut commented 2 years ago

It seems like the z is not being set correctly for some of these items image My best guess is that either there's an error in the parser, or the format for some items is inconsistent. I haven't taken a look at the parser yet though, just gathering information..

IsolatedLun commented 2 years ago

It was an error in the parser, since the DisplayName of the item is sometimes multiple words the parser just ignored it. (it uses regex)

IsolatedLun commented 2 years ago

I completely fixed this issue by just making the key an object it's DisplayName, instead of over complicating everything and having separate names!