Isoldhe / Battleship

Battleship game in C#
0 stars 1 forks source link

Display overhaul to master #13

Closed Isoldhe closed 5 years ago

Isoldhe commented 5 years ago

Right, so the master branch is a little behind. Let's merge everything if you're ok with my latest commit, which is in here somewhere in the Game class (the quit feature).

Atrixsanna commented 5 years ago

I'll merge the pull request since it looks like good and working code, and my comment is mostly a suggestion.

Uhm, I can't figure out how to create a pull request from VS. It just pushed my code to the remote branch. Anyway, I added the quit feature. "It ain't much, but it's honest work."

A pull request has to be on the server, since GitHub cannot check out your local commits or branches. As such you'll have to push a non-master branch every time you wish to create a pull request. I'd advise making a branch called after the feature you're working on or simply call it 'work_in_progress' if you have no name for it yet. You can then push that branch safely since its a new branch and make a pull request from that to master. The other option would be making a fork like I did, then push your changes to a new branch in the fork and make a pull request from that forked repo to this repo's master. However since you're the owner of this repository it would be kind of weird for you to fork it.. If you want to try this be my guest though, nothing lost in trying ^^